fix: link the Setup Required error page directly to /setup - #66
Merged
Conversation
Creating a jamfpro/okta automation before JAWA is configured raised a
'Setup Required' error page that dead-ended the user -- Back and
Dashboard only, no path to /setup where they actually need to go.
AutomationError already carried an optional link, but the two raise
sites passed none and the template rendered a link as a raw URL in a
new tab.
Now the raise sites pass link=/setup with a friendly label, and when a
link is present the error page renders it as the primary in-page action
button ('Go to Setup'), demoting Dashboard to secondary. Adds link_text
to AutomationError for the button label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an automation (jamfpro/okta) before JAWA is configured showed a "Setup Required" error page that dead-ended the user — only Back and Dashboard, with no path to
/setup, which is exactly where they need to go first (set the FQDN and link a Jamf Pro server).Fix
jamf_handler,okta_handler) now passlink="/setup"with a friendly label and a clearer message.AutomationErrorgains an optionallink_textfor the button label;_error_pageforwards it.error.html: when an error carries a link, it renders as the primary in-page action button ("Go to Setup →") and Dashboard demotes to secondary. Previously a link was rendered as a raw URL that opened in a new tab. When there's no link, Dashboard stays primary (unchanged).Tests
tests/test_setup_required.py— asserts the Setup Required page for both jamfpro and okta contains a direct in-page/setuplink with the "Go to Setup" label (and notarget="_blank"). Full suite green (92 passed), ruff clean.Targets
developfor the batched v3.2 release.