feat(graph-view): render DAG edges from span links in Trace Graph#3570
Open
SoumyaRaikwar wants to merge 4 commits intojaegertracing:mainfrom
Open
feat(graph-view): render DAG edges from span links in Trace Graph#3570SoumyaRaikwar wants to merge 4 commits intojaegertracing:mainfrom
SoumyaRaikwar wants to merge 4 commits intojaegertracing:mainfrom
Conversation
Signed-off-by: SoumyaRaikwar <somuraik@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
==========================================
+ Coverage 89.19% 89.22% +0.02%
==========================================
Files 330 330
Lines 9894 9917 +23
Branches 2567 2573 +6
==========================================
+ Hits 8825 8848 +23
Misses 927 927
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@yurishkuro please take a look whenever you have time., also should i test it with the example trace provided in issue? |
Contributor
Author
|
@jkowall @yurishkuro PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Previously, the Trace Graph view in the Jaeger UI only rendered parent-child edges based on the parentSpanID. Any additional references (such as multiple
FOLLOWS_FROMreferences or OTEL span links) were silently dropped, meaning true Directed Acyclic Graphs (DAGs) were visualized only as trees.This PR updates the trace graph rendering pipeline to include these additional edges:
span.linksto the DAG builder pipeline.screenshots


How was this change tested?
CHILD_OFandFOLLOWS_FROM) and verifying that the Trace Graph view natively renders the converging DAG edges.npm run lintreports 0 errors.Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.