Repository navigation
Conversation
jaeger-user-config.yaml and jaeger-ui-config.yaml passed the root context to the jaeger.annotations helper, which expects a dict with context and component keys. Setting commonAnnotations together with userconfig or uiconfig made helm template fail with a nil pointer. Call the helper like the other templates do, and cover the UI config map in the common labels/annotations CI values. Signed-off-by: Lewis Bertin <lewis@tactiqual.tech>
berlewis
requested review from
naseemkullah and
pavelnikolov
as code owners
September 30, 2026 20:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
jaeger-user-config.yamlandjaeger-ui-config.yamlpassed the root context tojaeger.annotations, which expects a dict, so settingcommonAnnotationswithuserconfigoruiconfigfailed with a nil pointer. Both now call the helper like the other templates, as proposed by @paripooranan in the issue. I also addeduiconfigto the common labels/annotations CI values so the UI config map path is rendered and installed in CI (userconfigreplaces the whole config, so it stays out of CI).Tested with the repro from the issue (fails on main, renders here) and on a kind cluster with
commonAnnotations,userconfiganduiconfig; the default render is unchanged.Which issue this PR fixes
Checklist
[jaeger]or[jaeger-operator])Written with AI assistance, reviewed and tested by me.