Repository navigation
Conversation
…proxy version Templates only read .Values.userconfig; README referenced a non-existent 'config' key in 3 places, which silently no-ops any override a user follows verbatim. Also synced the documented oauth2-proxy version to match values.yaml's actual default (v7.15.4). Refs jaegertracing#779 Signed-off-by: 0xkatana <m_kara@estin.dz>
H3xKatana
requested review from
naseemkullah and
pavelnikolov
as code owners
September 16, 2026 16:34
H3xKatana
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #779. README.md documented a
config:key at L12/L133/L225-228 that templates never read (only.Values.userconfigis used — see jaeger-user-config.yaml:1, jaeger-deploy.yaml:55,112,179, values.yaml:69). Following the README verbatim silently no-ops. Also fixed a stale comment in values.yaml:325, synced README's documented oauth2-proxy version to the real default in values.yaml (v7.15.4), and bumped the chart version per the immutability rule in CONTRIBUTING.md. DCO signed. Lint passes, templates render (default + both ci values files).