pgconn: add configurable max message body length#2558
Open
carter-ya wants to merge 1 commit into
Open
Conversation
c870425 to
f8fca46
Compare
Owner
|
Is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgconn.Config.MaxBodyLenand apply it topgproto3.FrontendduringConnectConfigandConstruct.Rationale
pgproto3.Frontendalready supportsSetMaxBodyLen, butpgconnusers currently need to reach through to the protocol frontend to configure it. Exposing the setting onpgconn.Configmakes it possible to reject unreasonable message bodies beforechunkReaderallocates the buffer.The default remains
0, so no maximum is enforced unless callers opt in. This preserves the existing behavior while allowing applications to configure a defensive limit.Testing
go test ./pgproto3 ./pgconn -run 'TestFrontendReceiveExceededMaxBodyLen|TestBackendReceiveExceededMaxBodyLen|TestConnectConfigMaxBodyLen|TestConfigCopyReturnsEqualConfig'