Skip to content

ci!: test on Java 17, 21, 25 - #192

Merged
jGleitz merged 35 commits into
v3from
jGleitz-patch-1
Mar 1, 2026
Merged

ci!: test on Java 17, 21, 25#192
jGleitz merged 35 commits into
v3from
jGleitz-patch-1

Conversation

@jGleitz

@jGleitz jGleitz commented Feb 27, 2026

Copy link
Copy Markdown
Owner

BREAKING CHANGE: testfiles supports only Java >= 17 now

Upgrade to gradle 9 and adapt plugins and build to it.

fixes #201

Copilot AI review requested due to automatic review settings February 27, 2026 16:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflow to test against more modern Java versions and switches to the Temurin distribution. The project targets Java 8 compatibility but tests against newer versions to ensure forward compatibility.

Changes:

  • Replaces Java 16 with Java 17 (LTS) and adds Java 24 and 25 to the test matrix
  • Updates JDK distribution from 'adopt' to 'temurin' (following AdoptOpenJDK's transition to Eclipse Adoptium)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings February 27, 2026 16:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
@jGleitz jGleitz changed the title ci: test on Java 8, 11, 17, 24, 25 ci: test on Java 11, 17, 24, 25 Feb 27, 2026
@jGleitz

jGleitz commented Feb 27, 2026

Copy link
Copy Markdown
Owner Author

@copilot please see the kotlin java target version to v11 everywhere

Copilot AI commented Feb 27, 2026

Copy link
Copy Markdown

@jGleitz I've opened a new pull request, #195, to work on those changes. Once the pull request is ready, I'll request review from you.

@jGleitz jGleitz changed the title ci: test on Java 11, 17, 24, 25 ci: test on Java 17, 24, 25 Feb 27, 2026
Copilot AI and others added 10 commits February 27, 2026 16:58
- CI workflow: Use temurin JDK, gradle/actions/setup-gradle for caching,
  SHA-pinned actions, should-run job, artifact-based test results
- Release workflow: Same JDK/caching changes, deploy-pages for docs
- Add test-report, dependency-graph, pull-request-title workflows
- Replace renovate.json with renovate.json5 using shared preset

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
- CI matrix: use [ 17, 24, 25 ] from base branch instead of [ 8, 11, 16 ]
- Release and dependency-graph: use JDK 17 instead of 11

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
- ci.yml: Add branch filter [ master, renovate/** ] for pushes, remove
  should-run guard job
- ci.yml: Add docs build job and deploy-docs job (deploys on master only)
- release.yml: Read Java version from .sdkmanrc, remove docs job (moved
  to CI)
- dependency-graph.yml: Read Java version from .sdkmanrc
- Create .sdkmanrc with java=17.0.13-tem

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
…25.0.2

- ci.yml: Merge docs job into build job as conditional steps
  (matrix.os == 'ubuntu-latest' && matrix.java-version == 25)
- release.yml, dependency-graph.yml: Use setup-java's native
  java-version-file: '.sdkmanrc' instead of separate sed step
- .sdkmanrc: Update to java=25.0.2-tem

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
…into copilot/align-github-actions-setup

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/release.yml
#	base/build.gradle.kts
#	build.gradle.kts
#	gradle/wrapper/gradle-wrapper.properties
#	kotest/build.gradle.kts
#	spek/build.gradle.kts
Adapt GitHub Actions for `main` default branch
Copilot AI review requested due to automatic review settings February 28, 2026 08:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:96

  • The Release Check step runs on pull_request events but relies on secrets.RELEASE_GITHUB_TOKEN. For PRs from forks this secret will be unavailable, which can cause semantic-release to fail and make CI red. Consider gating this job/step to push events only, or falling back to ${{ github.token }} (and/or running semantic-release --dry-run on PRs) so PR validation doesn't depend on privileged secrets.
  release:
    name: Release Check
    runs-on: ubuntu-latest
    needs: build
    steps:
      - name: Checkout
        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

      - name: Setup Node.js
        uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
        with:
          node-version: lts/*

      - name: Release Check
        env:
          GITHUB_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}
        run: npx semantic-release

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread gradle/wrapper/gradle-wrapper.properties Outdated
@jGleitz

jGleitz commented Feb 28, 2026

Copy link
Copy Markdown
Owner Author

@copilot I was mistaken about the best flow for the CI. Please change the GitHub actions so that the docs are build and published only in the release pipeline. But please do it such that there's only on job in the release pipeline, not two. Pushing the docs to GitHub pages should happen only after the artefacts have been published successfully with Gradle.

However, the CI pipeline should still build the docs and publish them as an artifact on the run

Copilot AI review requested due to automatic review settings February 28, 2026 17:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread settings.gradle.kts
Migrate Dokka to V2 (2.1.0), aligned with string-notation
@jGleitz

jGleitz commented Feb 28, 2026

Copy link
Copy Markdown
Owner Author

@copilot please improve the CI by running the release check only on main

Copilot AI commented Feb 28, 2026

Copy link
Copy Markdown

@jGleitz I've opened a new pull request, #200, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 28, 2026 20:04
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pull-request-title.yml
Comment thread kotest/build.gradle.kts Outdated
Comment thread spek/build.gradle.kts Outdated
@jGleitz
jGleitz changed the base branch from main to v3 February 28, 2026 20:36
Copilot AI and others added 6 commits February 28, 2026 21:40
- Upgrade io.github.gradle-nexus.publish-plugin from 1.3.0 to 2.0.0
  (fixes ClassNotFoundException for DefaultDecoratedConvention removed in Gradle 9)
- Rename closeAndReleaseStagingRepository to closeAndReleaseStagingRepositories
  (breaking change in nexus plugin 2.0.0)
- Replace deprecated KotlinCompilerVersion with version-less kotlin() dependency
- Migrate kotlinOptions DSL to compilerOptions DSL (deprecated in Kotlin 2.3.10)
- Replace -Xopt-in with -opt-in compiler flag
- Replace deprecated String.toLowerCase() with lowercase()
- Replace deprecated buildDir with layout.buildDirectory
- Add junit-platform-launcher dependency (required by Gradle 9)

Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: jGleitz <4305652+jGleitz@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jGleitz jGleitz linked an issue Mar 1, 2026 that may be closed by this pull request
# Conflicts:
#	build.gradle.kts
#	gradle/wrapper/gradle-wrapper.jar
#	gradle/wrapper/gradle-wrapper.properties
#	gradlew
#	gradlew.bat
@jGleitz
jGleitz merged commit b394124 into v3 Mar 1, 2026
10 checks passed
@jGleitz
jGleitz deleted the jGleitz-patch-1 branch March 1, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails

3 participants