Skip to content

Fix ground plane rendering by updating near_world convention in material #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssheorey wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

Fix ground plane rendering by updating near_world convention in material #7465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cpp/open3d/visualization/gui/Materials/infiniteGroundPlane.mat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,14 @@ material {
vertex {
void materialVertex(inout MaterialVertexInputs material) {
float4 p = getPosition();
material.near_world = getWorldFromClipMatrix() * float4(p.x, p.y, 0.0, 1.0);
// getWorldFromClipMatrix() expects z in "inverted DX" convention
// (Filament >= v1.10): near = 1.0, far = 0.0 in [0,1].
// Using z=1.0 gives the near-plane world position for this pixel
// direction, which is the ray origin for ground-plane intersection.
// (In Filament v1.9.9 the matrix used GL-standard z where z=0.0
// approximated the near plane; that no longer holds after the
// VERTEX_DOMAIN_DEVICE z-conversion was introduced.)
material.near_world = getWorldFromClipMatrix() * float4(p.x, p.y, 1.0, 1.0);
material.near_world.xyz *= (1.0 / material.near_world.w);
}
}
Expand Down
Loading