Add Probe CRD and controller for fabric health assertions - #510
Merged
Conversation
felix-kaestner
force-pushed
the
readyness-probe
branch
4 times, most recently
from
August 19, 2026 16:40
b969c1f to
13f741d
Compare
Contributor
Author
|
Ping Probe apiVersion: networking.metal.ironcore.dev/v1alpha1
kind: Probe
spec:
deviceRef:
name: leaf1
ping:
address: 10.0.0.12
count: 3
packetSize: 1400
sourceInterface:
interfaceRef:
name: lo0
timeout: 5s
vrf:
name: default
schedule: '* * * * *'
type: Ping
status:
conditions:
- lastTransitionTime: "2026-08-20T14:48:01Z"
message: 3/3 packets received, avg 9.66ms
observedGeneration: 1
reason: ProbeSuccessful
status: "True"
type: Ready
lastRunTime: "2026-08-20T14:49:00Z"
nextRunTime: "2026-08-20T14:50:00Z"
ping:
avgTime: 9.66ms
maxTime: 10.723ms
minTime: 8.319999ms
received: 3
sent: 3MAC Table Entry Probe apiVersion: networking.metal.ironcore.dev/v1alpha1
kind: Probe
spec:
deviceRef:
name: leaf1
macTableEntry:
macAddress: "00:00:00:00:00:02"
vlan:
id: 10
type: MACTableEntry
status:
conditions:
- lastTransitionTime: "2026-08-20T14:55:00Z"
message: MAC 00:00:00:00:00:02 found
observedGeneration: 1
reason: ProbeSuccessful
status: "True"
type: Ready
lastRunTime: "2026-08-20T14:55:00Z"Route Prefix Route Probe apiVersion: networking.metal.ironcore.dev/v1alpha1
kind: Probe
spec:
deviceRef:
name: leaf1
routePresence:
prefix: 192.168.10.0/24
vrf:
name: default
type: RoutePresence
status:
conditions:
- lastTransitionTime: "2026-08-20T14:56:52Z"
message: prefix 192.168.10.0/24 found
observedGeneration: 1
reason: ProbeSuccessful
status: "True"
type: Ready
lastRunTime: "2026-08-20T14:56:52Z"VTEP Connectivity Probe apiVersion: networking.metal.ironcore.dev/v1alpha1
kind: Probe
spec:
deviceRef:
name: leaf1
type: VTEPPeerConnectivity
vtepPeerConnectivity:
expectedPeers:
- 10.0.1.12
status:
conditions:
- lastTransitionTime: "2026-08-20T14:58:45Z"
message: 1/1 expected VTEP peers up
observedGeneration: 1
reason: ProbeSuccessful
status: "True"
type: Ready
lastRunTime: "2026-08-20T14:58:45Z" |
felix-kaestner
marked this pull request as ready for review
August 20, 2026 15:01
felix-kaestner
force-pushed
the
readyness-probe
branch
from
August 20, 2026 15:01
13f741d to
6a18b55
Compare
hardikdr
added
the
area/switch-automation
nikatza
reviewed
Aug 27, 2026
nikatza
left a comment
nikatza
left a comment
Contributor
There was a problem hiding this comment.
I left some comments but this is a really cool contribution!
felix-kaestner
force-pushed
the
readyness-probe
branch
4 times, most recently
from
August 28, 2026 15:50
2ddc353 to
1d956fa
Compare
Introduce the Probe resource in the core API group for asserting operational health of network devices. A Probe runs one-shot or on a cron schedule and supports four assertion types: - Ping: ICMP echo from device with optional VRF/source interface - MACTableEntry: assert MAC exists in forwarding table - RoutePresence: assert IP prefix exists in routing table - VTEPPeerConnectivity: assert VTEP peers are up Add ProbeProvider interface with per-type methods, controller with full reconcile loop (schedule, lock, connect, dispatch, status), reference resolution for Interface/VRF/VLAN with not-found, cross-device, and readiness checks. Add watchers for Device, Interface, VRF, and VLAN ready-state changes. Add VLANSource and InterfaceSource/VRFSource shared types for name-or-ref resolution with CEL mutual exclusivity validation. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
readyness-probe
branch
from
September 1, 2026 08:39
1d956fa to
19051ae
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
nikatza
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the Probe resource in the core API group for asserting operational health of network devices. A Probe runs one-shot or on a cron schedule and supports four assertion types:
Add ProbeProvider interface with per-type methods, controller with full reconcile loop (schedule, lock, connect, dispatch, status), reference resolution for Interface/VRF/VLAN with not-found, cross-device, and readiness checks. Add watchers for Device, Interface, VRF, and VLAN ready-state changes.
Add VLANSource and InterfaceSource/VRFSource shared types for name-or-ref resolution with CEL mutual exclusivity validation.