Migrate from helm/v1-alpha (deprecated) to helm/v2-alpha #905
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,35 @@ | ||
| name: Test Chart | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths-ignore: | ||
| - 'docs/**' | ||
| - '**/*.md' | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| test-e2e: | ||
| permissions: | ||
| contents: read | ||
| name: Run on Ubuntu | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| IMG: controller:latest | ||
| steps: | ||
| - name: Clone the code | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod | ||
|
|
||
| - name: Install the latest version of kind | ||
| run: | | ||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-$(go env GOARCH) | ||
| chmod +x ./kind | ||
|
Comment on lines
31
to
33
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🌐 Web query:
💡 Result: Official, CI-friendly way (with version pinning + checksum verification) is to download the exact kind binary release asset for your OS/arch at a pinned version, also download the matching Citations:
🏁 Script executed: #!/bin/bash
set -euo pipefail
sed -n '1,120p' .github/workflows/test-chart.yml | nl -ba | sed -n '20,60p'Repository: ironcore-dev/metal-operator Length of output: 114 🏁 Script executed: #!/bin/bash
set -euo pipefail
# Show numbered lines around the reported location (use cat -n since nl isn't available)
cat -n .github/workflows/test-chart.yml | sed -n '20,60p'Repository: ironcore-dev/metal-operator Length of output: 1454 Pin In 🤖 Prompt for AI Agents |
||
| sudo mv ./kind /usr/local/bin/kind | ||
|
|
||
|
|
@@ -47,26 +41,40 @@ jobs: | |
|
|
||
| - name: Prepare metal-operator | ||
| run: | | ||
| go mod tidy | ||
| make docker-build | ||
| kind load docker-image $IMG | ||
|
|
||
| - name: Install Helm | ||
| run: make install-helm | ||
|
|
||
| - name: Lint Helm Chart | ||
| run: | | ||
| helm lint ./dist/chart | ||
|
|
||
|
|
||
| - name: Install cert-manager via Helm (wait for readiness) | ||
| run: | | ||
| helm repo add jetstack https://charts.jetstack.io | ||
| helm repo update | ||
| helm install cert-manager jetstack/cert-manager \ | ||
| --namespace cert-manager \ | ||
| --create-namespace \ | ||
| --set crds.enabled=true \ | ||
| --wait \ | ||
| --timeout 300s | ||
|
afritzler marked this conversation as resolved.
|
||
|
|
||
| # TODO: Uncomment if Prometheus is enabled | ||
| # - name: Install Prometheus Operator CRDs | ||
| # run: | | ||
| # helm repo add prometheus-community https://prometheus-community.github.io/helm-charts | ||
| # helm repo update | ||
| # helm install prometheus-crds prometheus-community/prometheus-operator-crds | ||
|
|
||
| - name: Deploy manager via Helm | ||
| run: | | ||
| make helm-deploy | ||
|
|
||
| - name: Check Helm release status | ||
| run: | | ||
| make helm-status | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,9 @@ layout: | |
| - go.kubebuilder.io/v4 | ||
| plugins: | ||
| autoupdate.kubebuilder.io/v1-alpha: {} | ||
| helm.kubebuilder.io/v2-alpha: | ||
| manifests: dist/install.yaml | ||
| output: dist | ||
| projectName: metal-operator | ||
| repo: github.com/ironcore-dev/metal-operator | ||
| resources: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,8 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| images: | ||
| - name: controller | ||
| newName: controller | ||
| newTag: latest | ||
| resources: | ||
| - manager.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,14 @@ | ||
| apiVersion: v2 | ||
| name: metal-operator | ||
| description: A Helm chart to distribute metal-operator | ||
| type: application | ||
|
|
||
| version: 0.1.0 | ||
| appVersion: "0.1.0" | ||
|
|
||
| keywords: | ||
| - kubernetes | ||
| - operator | ||
|
|
||
| annotations: | ||
| kubebuilder.io/generated-by: kubebuilder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Thank you for installing {{ .Chart.Name }}. | ||
|
|
||
| Your release is named {{ .Release.Name }}. | ||
|
|
||
| The controller and CRDs have been installed in namespace {{ .Release.Namespace }}. | ||
|
|
||
| To verify the installation: | ||
|
|
||
| kubectl get pods -n {{ .Release.Namespace }} | ||
| kubectl get customresourcedefinitions | ||
|
|
||
| To learn more about the release, try: | ||
|
|
||
| $ helm status {{ .Release.Name }} -n {{ .Release.Namespace }} | ||
| $ helm get all {{ .Release.Name }} -n {{ .Release.Namespace }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,63 @@ | ||
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "metal-operator.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| If release name contains chart name it will be used as a full name. | ||
| */}} | ||
| {{- define "metal-operator.fullname" -}} | ||
| {{- if .Values.fullnameOverride }} | ||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- $name := default .Chart.Name .Values.nameOverride }} | ||
| {{- if contains $name .Release.Name }} | ||
| {{- .Release.Name | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Namespace for generated references. | ||
| Always uses the Helm release namespace. | ||
| */}} | ||
| {{- define "metal-operator.namespaceName" -}} | ||
| {{- .Release.Namespace }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Resource name with proper truncation for Kubernetes 63-character limit. | ||
| Takes a dict with: | ||
| - .suffix: Resource name suffix (e.g., "metrics", "webhook") | ||
| - .context: Template context (root context with .Values, .Release, etc.) | ||
| Dynamically calculates safe truncation to ensure total name length <= 63 chars. | ||
| */}} | ||
| {{- define "metal-operator.resourceName" -}} | ||
| {{- $fullname := include "metal-operator.fullname" .context }} | ||
| {{- $suffix := .suffix }} | ||
| {{- $maxLen := sub 62 (len $suffix) | int }} | ||
| {{- if gt (len $fullname) $maxLen }} | ||
| {{- printf "%s-%s" (trunc $maxLen $fullname | trimSuffix "-") $suffix | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s" $fullname $suffix | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| ServiceAccount name to use. | ||
| If serviceAccount.enable is false and serviceAccount.name is set, use that name. | ||
| Otherwise, use the standard resourceName helper with "controller-manager" suffix. | ||
| */}} | ||
| {{- define "metal-operator.serviceAccountName" -}} | ||
| {{- if and (not (.Values.serviceAccount.enable | default true)) .Values.serviceAccount.name }} | ||
| {{- .Values.serviceAccount.name }} | ||
| {{- else }} | ||
| {{- include "metal-operator.resourceName" (dict "suffix" "controller-manager" "context" .) }} | ||
| {{- end }} | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| {{- if and .Values.certManager.enable .Values.metrics.enable .Values.metrics.secure }} | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/name: {{ include "metal-operator.name" . }} | ||
| helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| name: {{ include "metal-operator.resourceName" (dict "suffix" "metrics-certs" "context" $) }} | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| dnsNames: | ||
| - {{ include "metal-operator.resourceName" (dict "suffix" "controller-manager-metrics-service" "context" $) }}.{{ .Release.Namespace }}.svc | ||
| - {{ include "metal-operator.resourceName" (dict "suffix" "controller-manager-metrics-service" "context" $) }}.{{ .Release.Namespace }}.svc.cluster.local | ||
| issuerRef: | ||
| kind: Issuer | ||
| name: {{ include "metal-operator.resourceName" (dict "suffix" "selfsigned-issuer" "context" $) }} | ||
| secretName: metrics-server-cert | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| {{- if .Values.certManager.enable }} | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Issuer | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/name: {{ include "metal-operator.name" . }} | ||
| helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| name: {{ include "metal-operator.resourceName" (dict "suffix" "selfsigned-issuer" "context" $) }} | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| selfSigned: {} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| {{- if .Values.certManager.enable }} | ||
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/name: {{ include "metal-operator.name" . }} | ||
| helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| name: {{ include "metal-operator.resourceName" (dict "suffix" "serving-cert" "context" $) }} | ||
| namespace: {{ .Release.Namespace }} | ||
| spec: | ||
| dnsNames: | ||
| - {{ include "metal-operator.resourceName" (dict "suffix" "webhook-service" "context" $) }}.{{ .Release.Namespace }}.svc | ||
| - {{ include "metal-operator.resourceName" (dict "suffix" "webhook-service" "context" $) }}.{{ .Release.Namespace }}.svc.cluster.local | ||
| issuerRef: | ||
| kind: Issuer | ||
| name: {{ include "metal-operator.resourceName" (dict "suffix" "selfsigned-issuer" "context" $) }} | ||
| secretName: webhook-server-cert | ||
| {{- end }} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.