Skip to content

Improve BMC connection reliability and error logging #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xkonni wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve BMC connection reliability and error logging #758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions bmc/redfish.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,22 @@ package bmc
import (
"context"
"crypto/rand"
"crypto/tls"
"encoding/json"
"errors"
"fmt"
"io"
"maps"
"math/big"
"net/http"
"net/url"
"slices"
"strings"
"time"

"github.com/stmcginnis/gofish"
"github.com/stmcginnis/gofish/schemas"
"golang.org/x/net/http2"
"k8s.io/apimachinery/pkg/api/resource"
"k8s.io/apimachinery/pkg/util/wait"

Expand Down Expand Up @@ -83,15 +86,28 @@ func (e *InvalidBIOSSettingsError) Error() string {

// newRedfishBaseBMCClient creates a new RedfishBaseBMC with the given connection details (internal use only).
func newRedfishBaseBMCClient(ctx context.Context, options Options) (*RedfishBaseBMC, error) {
transport := &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, //nolint:gosec
Copy link
Copy Markdown
Member

@afritzler afritzler Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make this configurable.

Copy link
Copy Markdown
Contributor

@stefanhipfel stefanhipfel Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#739

}
if err := http2.ConfigureTransport(transport); err != nil {
return nil, fmt.Errorf("failed to configure HTTP/2 transport: %w", err)
}
clientConfig := gofish.ClientConfig{
Endpoint: options.Endpoint,
Username: options.Username,
Password: options.Password,
Insecure: true,
BasicAuth: options.BasicAuth,
Endpoint: options.Endpoint,
Username: options.Username,
Password: options.Password,
BasicAuth: options.BasicAuth,
HTTPClient: &http.Client{Transport: transport},
NoModifyTransport: true,
}
client, err := gofish.ConnectContext(ctx, clientConfig)
if err != nil {
var urlErr *url.Error
if errors.As(err, &urlErr) {
ctrl.LoggerFrom(ctx).V(1).Info("Could not connect to BMC endpoint", "endpoint", options.Endpoint, "op", urlErr.Op, "errorType", fmt.Sprintf("%T", urlErr.Unwrap()), "error", err)
} else {
ctrl.LoggerFrom(ctx).V(1).Info("Could not connect to BMC endpoint", "endpoint", options.Endpoint, "errorType", fmt.Sprintf("%T", err), "error", err)
}
return nil, err
}
bmc := &RedfishBaseBMC{client: client}
Expand Down
Loading