Analyzer code actions show the replacement, not just the code - #1549
Open
Thorium wants to merge 1 commit into
Open
Analyzer code actions show the replacement, not just the code#1549Thorium wants to merge 1 commit into
Thorium wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1548
An analyzer can attach several actions to one span - a primary fix and alternatives - and titling each "Fix FR0136" renders them as identical menu entries, leaving the user to guess. The replacement text is the clearest possible label, so the title becomes "Fix FR0136 -> Guid.NewGuid()" (first line, capped at 50 chars); pure deletions fall back to the diagnostic message's first line, and only an empty message leaves the bare code.