fix(ui): auto-add newly created boards#9193
Open
YUHAO-corn wants to merge 1 commit into
Open
Conversation
YUHAO-corn
requested review from
Pfannkuchensack,
blessedcoolant,
dunkeroni and
lstein
as code owners
YUHAO-corn
force-pushed
the
yuhao/fix-new-board-auto-add-9169
branch
from
392dc16 to
e770bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a gallery board UX inconsistency: when "Auto-Assign Board on Click" is enabled, creating a new board now updates the auto-add board to the newly-created board, matching the behavior of clicking an existing board. Previously, the UI selected the new board but generated images still saved to the previous auto-add board until the user clicked the board again.
This also adds a focused regression test for the created-board action sequence.
Related Issues / Discussions
Closes #9169
QA Instructions
Validated locally with:
pnpm -C invokeai/frontend/web test:run src/features/gallery/components/Boards/BoardsList/AddBoardButton.test.tsxpnpm -C invokeai/frontend/web test:runpnpm -C invokeai/frontend/web lint:tscpnpm -C invokeai/frontend/web lint:eslintpnpm -C invokeai/frontend/web lint:prettierpnpm -C invokeai/frontend/web exec eslint src/features/gallery/components/Boards/BoardsList/AddBoardButton.tsx src/features/gallery/components/Boards/BoardsList/AddBoardButton.test.tsxpnpm -C invokeai/frontend/web exec prettier --check src/features/gallery/components/Boards/BoardsList/AddBoardButton.tsx src/features/gallery/components/Boards/BoardsList/AddBoardButton.test.tsxMerge Plan
No special merge handling needed.
Checklist
What's Newcopy (if doing a release after this PR) N/A