Support Hugging Face blob file URLs#9167
Open
C2015 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
python
C2015
requested review from
JPPhoto,
blessedcoolant,
dunkeroni and
lstein
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/blob/into direct/resolve/download URLs before queuing a generic URL download.Fixes #6227
Testing
python3 -m py_compile invokeai/app/services/model_install/model_install_default.py tests/app/services/model_install/test_model_install.pygit diff --checkpython3 -m pytest tests/app/services/model_install/test_model_install.py -k huggingface_blob_url_uses_resolve_download_urlcould not run locally becausepytestis not installed in this environment.