Switch page display to be 0-indexed#1544
Merged
Merged
Conversation
(per bk request)
pezvi
force-pushed
the
br-8444-0-indexed-page-number-display
branch
from
9974c52 to
f0d72d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1544 +/- ##
=======================================
Coverage 68.96% 68.96%
=======================================
Files 65 65
Lines 5559 5559
Branches 1231 1231
=======================================
Hits 3834 3834
Misses 1691 1691
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdrini
approved these changes
May 15, 2026
Contributor
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm, thank you! Tested on netlify and is working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per bk request, because it was causing confusion when the number in the UI was different from the n-number in the URL (eg
/page/n0).