Skip to content

Mode2UpLit: skip page-flip when a text selection is active #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbuckner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mode2UpLit: skip page-flip when a text selection is active #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/BookReader/Mode2UpLit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,15 @@ export class Mode2UpLit extends LitElement {

if (ev.which != 1) return;

// Don't flip the page if the user is completing a text-selection
// drag. The page-flip handler runs on `mouseup`, so releasing the
// mouse at the end of a selection would otherwise trigger
// `br.left()` / `br.right()` and clobber the selection. The text
// selection plugin's own mouseup handler stops propagation when the
// mouseup lands on a word, but not when it lands in blank space
// between words or on the page margin.
if (window.getSelection?.()?.toString().trim()) return;

const $page = $(ev.target).closest('.BRpagecontainer');
if (!$page.length) return;
if ($page.data('side') == 'L') {
Expand Down
Loading