forked from microsoft/onnxruntime
-
Notifications
You must be signed in to change notification settings - Fork 61
[CVS-188379] Add sxs manifest support for openvino.dll #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n1harika
wants to merge
11
commits into
SxS_Manifest
Choose a base branch
from
niharika/sxs_manifest
base: SxS_Manifest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1892962
Add sxs manifest support for openvino.dll
n1harika 23fa71f
Merge branch 'ovep-develop' into niharika/sxs_manifest
n1harika 27231a7
Remove signatures before embedding manifests
n1harika 5a7b680
copilot review
n1harika 9d33480
copilot review 2
n1harika 183efbe
Merge branch 'ovep-develop' into niharika/sxs_manifest
n1harika 0cdd53a
copilot review 3
n1harika 2324bb6
coplito review 4
n1harika 7d98ea6
revert cmake change
n1harika 8f89679
all configs are staged- revoke copilot comment
n1harika 96c47ce
Merge branch 'ovep-develop' into niharika/sxs_manifest
MayureshV1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <!-- | ||
| Windows SxS private assembly manifest for the OpenVINO runtime bundled with | ||
| onnxruntime_providers_openvino.dll (legacy EP). | ||
| Installed as bin/openvino_runtime.manifest alongside the provider DLL. | ||
| Version matches the ORT version (MAJOR.MINOR.PATCH.0). | ||
| Configured at build time by CMakeLists.txt — do not edit by hand. | ||
| --> | ||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | ||
| <assemblyIdentity type="win32" name="openvino_runtime" | ||
| version="@ORT_SXS_VERSION@.0" processorArchitecture="amd64" /> | ||
| @ORT_SXS_ASSEMBLY_FILE_ENTRIES@</assembly> | ||
|
n1harika marked this conversation as resolved.
n1harika marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <!-- | ||
| SxS dependency manifest embedded into each OV/TBB DLL and | ||
| onnxruntime_providers_openvino.dll. | ||
| Declares a dependency on the openvino_runtime private assembly at the EP version, | ||
| matching the version in assembly.manifest.in. | ||
| Generated by cmake/sxs/embed_manifest.cmake — do not edit by hand. | ||
| --> | ||
| <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> | ||
| <assemblyIdentity type="win32" name="${DLL_BASE_NAME}" | ||
| version="${EP_FILE_VERSION}" processorArchitecture="amd64" /> | ||
|
n1harika marked this conversation as resolved.
|
||
| <dependency> | ||
| <dependentAssembly> | ||
| <assemblyIdentity type="win32" name="openvino_runtime" | ||
| version="${EP_FILE_VERSION}" processorArchitecture="amd64" /> | ||
|
n1harika marked this conversation as resolved.
|
||
| </dependentAssembly> | ||
|
n1harika marked this conversation as resolved.
|
||
| </dependency> | ||
| </assembly> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright (C) Intel Corporation | ||
| # Licensed under the MIT License | ||
| # | ||
| # cmake -P script: embed a manifest file into a PE binary as RT_MANIFEST resource ID 2. | ||
| # | ||
| # Variables (passed via -D): | ||
| # CMAKE_MT — absolute path to mt.exe | ||
| # DLL_PATH — absolute path to the PE file to modify | ||
| # MANIFEST_PATH — absolute path to the .manifest file to embed | ||
| cmake_minimum_required(VERSION 3.28) | ||
|
|
||
| execute_process( | ||
| COMMAND "${CMAKE_MT}" -nologo | ||
| "-manifest" "${MANIFEST_PATH}" | ||
| "-outputresource:${DLL_PATH}\;2" | ||
| RESULT_VARIABLE _rc | ||
| OUTPUT_VARIABLE _out | ||
| ERROR_VARIABLE _err | ||
| ) | ||
|
|
||
| if(NOT _rc EQUAL 0) | ||
| message(FATAL_ERROR | ||
| "embed_manifest: mt.exe failed for '${DLL_PATH}' (exit ${_rc}):\n${_out}${_err}") | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Copyright (C) Intel Corporation | ||
| # Licensed under the MIT License | ||
| # | ||
| # cmake -P script: remove the Authenticode digital signature from a PE file. | ||
| # | ||
| # Variables (passed via -D): | ||
| # SIGNTOOL — absolute path to signtool.exe | ||
| # DLL_PATH — absolute path to the PE file | ||
| # | ||
| # Uses signtool verify to detect whether the file is signed before attempting | ||
| # removal, so unsigned files are skipped cleanly without parsing error messages. | ||
| cmake_minimum_required(VERSION 3.28) | ||
|
|
||
| execute_process( | ||
| COMMAND "${SIGNTOOL}" verify /pa "${DLL_PATH}" | ||
| RESULT_VARIABLE _signed | ||
| OUTPUT_QUIET ERROR_QUIET | ||
| ) | ||
|
|
||
| if(NOT _signed EQUAL 0) | ||
| message(STATUS "remove_signature: '${DLL_PATH}' is not signed — skipped") | ||
| return() | ||
| endif() | ||
|
|
||
| execute_process( | ||
| COMMAND "${SIGNTOOL}" remove /s "${DLL_PATH}" | ||
| RESULT_VARIABLE _rc | ||
| OUTPUT_VARIABLE _out | ||
| ERROR_VARIABLE _err | ||
| ) | ||
|
|
||
| if(NOT _rc EQUAL 0) | ||
| message(FATAL_ERROR | ||
| "remove_signature: signtool remove failed for '${DLL_PATH}' (exit ${_rc}):\n${_out}${_err}") | ||
| endif() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.