Skip to content

fix(ui): prevent iterator input field overlapping when content is long #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NJX-njx wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix(ui): prevent iterator input field overlapping when content is long #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...kit/src/view/pipeline-builder/components/iterator-editor/iterator-input/IteratorInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const IteratorInput = ({ className }: { className?: string }) => {
Input
</p>
</div>
<div className="flex flex-row items-center gap-x-2">
<div className="flex min-w-0 flex-1 flex-row items-center gap-x-2">
<Select.Root
value={selectedInputOption?.path}
onValueChange={(value) => {
Expand Down Expand Up @@ -120,7 +120,7 @@ export const IteratorInput = ({ className }: { className?: string }) => {
}
}}
>
<Select.Trigger className="!w-[245px]">
<Select.Trigger className="!min-w-[300px] !flex-1">
<Select.Value aria-label={selectedInputOption?.path}>
{selectedInputOption ? (
<p className="rounded bg-semantic-accent-bg px-2 py-0.5 text-semantic-accent-default product-body-text-4-medium">
Expand Down
8 changes: 4 additions & 4 deletions ...t/src/view/pipeline-builder/components/iterator-editor/iterator-output/IteratorOutput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@ export const OutputSet = ({
disabledDeleteButton?: boolean;
}) => {
return (
<div key={outputKey} className="flex flex-row items-center gap-x-3">
<div key={outputKey} className="flex flex-row flex-wrap items-center gap-x-3">
<p className="text-semantic-fg-primary product-body-text-3-semibold">
{outputKey}
</p>
<div className="flex flex-row gap-x-2">
<p className="text-semantic-fg-secondary product-body-text-4-semibold">
<div className="flex min-w-0 flex-1 flex-row items-center gap-x-2">
Comment on lines +62 to +66

Copilot AI Mar 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flex-wrap is enabled on this row but only gap-x-3 is set. When wrapping occurs, the second line will have no vertical spacing and can look cramped (or appear like elements are colliding). Consider adding a gap-y-* (or switching to gap-*) to provide consistent spacing when items wrap (similar to other flex-wrap rows in the codebase).

Copilot uses AI. Check for mistakes.
<p className="shrink-0 text-semantic-fg-secondary product-body-text-4-semibold">
array of
</p>
<OutputValueInput outputKey={outputKey} />
</div>
<OutputValueInput outputKey={outputKey} />
{disabledDeleteButton ? null : (
<DeleteOutputButton outputKey={outputKey} />
)}
Expand Down
2 changes: 1 addition & 1 deletion ...src/view/pipeline-builder/components/iterator-editor/iterator-output/OutputValueInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const OutputValueInput = ({ outputKey }: { outputKey: string }) => {
}, [tempSavedNodesForEditingIteratorFlow, editingIteratorID, outputKey]);

return (
<Input.Root className="!h-8 !w-[250px]">
<Input.Root className="!h-8 !min-w-[250px] !flex-1">
<Input.Core
className="!product-body-text-4-medium"
value={outputValue}
Expand Down
Loading