Skip to content

Normalize Newline Characters for SMS Count #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ba5liel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Normalize Newline Characters for SMS Count #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SMSCounter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ public function getAddedPortugueseGsm7bitExMap()
*/
public function count($text)
{
//Implemented normalization of newline characters in the SMS count function to ensure consistent and accurate SMS length calculations across different platforms.
//This fix standardizes the handling of newlines by converting `\r\n` to `\n`, addressing the issue where SMS parts were calculated differently due to varying newline character lengths in different operating systems.

$text = str_replace("\r\n", "\n", $message)
return $this->doCount($text, false);
}

Expand Down