Skip to content

Increase idle_in_transaction timeout for snapshot copy - #2884

Merged
dwwoelfel merged 1 commit into
mainfrom
idle
Aug 28, 2026
Merged

Increase idle_in_transaction timeout for snapshot copy#2884
dwwoelfel merged 1 commit into
mainfrom
idle

Conversation

@dwwoelfel

Copy link
Copy Markdown
Contributor

Increases the idle_in_transaction timeout for the snapshot copy so that we can run the copy on the prod db instead of creating a clone.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b4b1ce97-24da-412c-b36f-35b24e804946

📥 Commits

Reviewing files that changed from the base of the PR and between d68c953 and 6f8a095.

📒 Files selected for processing (1)
  • server/src/instant/backup.clj

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The backup snapshot flow sets idle_in_transaction_session_timeout to one hour on the query connection before creating snapshot-datasource.

Changes

Backup snapshot timeout

Layer / File(s) Summary
Configure snapshot transaction timeout
server/src/instant/backup.clj
process-with-snapshot sets PostgreSQL's idle_in_transaction_session_timeout to 3600000 on the query connection before wrapping it in snapshot-datasource.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 6f8a0

The snapshot copy can now keep its transaction open for up to one hour, enabling copying from the production database instead of a clone; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: increasing the idle-in-transaction timeout for snapshot copying.
Description check ✅ Passed The description explains that the timeout increase enables snapshot copying on the production database instead of requiring a clone.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stopachka stopachka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big timeout!

@dwwoelfel
dwwoelfel merged commit ad134cd into main Aug 28, 2026
34 checks passed
@dwwoelfel
dwwoelfel deleted the idle branch August 28, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants