Skip to content

[Explorer] Render boolean values #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nezaj merged 3 commits into from
Aug 4, 2026
Merged

[Explorer] Render boolean values #2830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c1be91
[Explorer] Render boolean values
nezaj Aug 4, 2026
7cd8592
sm
nezaj Aug 4, 2026
213abba
Bump v1.0.59
nezaj Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions client/packages/components/src/components/explorer/inner-explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ import { isObject } from 'lodash';
import { EditNamespaceDialog } from './edit-namespace-dialog';
import { EditRowDialog, isEditableExplorerAttr } from './edit-row-dialog';
import copy from 'copy-to-clipboard';
import { formatVal } from './format-value';

const fallbackItems: any[] = [];

Expand Down Expand Up @@ -539,10 +540,7 @@ export const InnerExplorer: React.FC<{
return info.row.original[attr.name];
}
}
if (isObject(info.row.original[attr.name])) {
return <Val data={info.row.original[attr.name]}></Val>;
}
return info.row.original[attr.name];
return formatVal(info.row.original[attr.name]);
},
});
});
Expand Down Expand Up @@ -1469,14 +1467,6 @@ export const InnerExplorer: React.FC<{
);
};

function formatVal(data: any, pretty?: boolean): string {
if (isObject(data)) {
return JSON.stringify(data, null, pretty ? 2 : undefined);
}

return String(data);
}

function Val({ data, pretty }: { data: any; pretty?: boolean }) {
const props = useExplorerProps();
const sanitized = formatVal(data, pretty);
Expand Down
9 changes: 1 addition & 8 deletions client/packages/components/src/components/explorer/table-components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import { isObject } from 'lodash';
import copy from 'copy-to-clipboard';
import { useExplorerDialog, useExplorerProps, useExplorerState } from '.';
import { TableColMeta } from './inner-explorer';
import { formatVal } from './format-value';

export const TableHeader = ({
header,
Expand Down Expand Up @@ -397,14 +398,6 @@ function isCopyableCellValue(
return true;
}

function formatVal(data: any, pretty?: boolean): string {
if (isObject(data)) {
return JSON.stringify(data, null, pretty ? 2 : undefined);
}

return String(data);
}

function Val({ data, pretty }: { data: any; pretty?: boolean }) {
const sanitized = formatVal(data, pretty);
const explorerProps = useExplorerProps();
Expand Down
Loading