Update installation instruction plus minor autoconfig fix#164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the recent NEMI workshop in Trondheim, we had a practical dedicated to installing and configuring Instamatic; for its purpose, with great help of @magnunor I managed to investigate successful Instamatic installation routines. As we noticed,
PyCifRWis an indirect dependency of Instamatic that needs to be either compiled (requires heavy C++ machinery) or pulled pre-compiled from conda-forge. Either of these solutions is not exactly obvious, so I decided to update the README.MD to include this detail there to save a few hours to any potential new users tacking with this issue later.On another side, as Andy Steward reported, for a very long time Instamatic had a typo that prevented
instamatic.autoconfig.exefrom running properly. The typo did nothing but raised a big and scary exception message. Here I fix it.Since this does not affect the core Instamatic code whatsoever, I intend to merge it in a few days, unless questions are raised.