Fix diffraction#1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original emulator code was developed by @viljarjf based on the assumption that the Diffsims PR #232, pyxem/diffsims#232, will be merged into the main branch. Unfortunately, this has not come to fruition in the last year, and it unlikely to do so at all. This is a shame, because introducing changes from this PR #232 would improve simulation time by a factor of 2 to 3. Unfortunately, I do not have the time right now to take care of said PR.
With the changes to diffsims not pushed to the main branch, the code for simulating diffraction patterns in the emulator was left unusable. It imported objects and used methods that were defined only on said branch. Consequently, switching to diffraction mode at any time crashed the emulator.
This small patch reverts or at least prevents some of the 232-based changes from running, unless the functionality is available. Consequently, if diffsims PR 232 ever comes to be included in any form, the speed of the simulations will improve. For the time being, the speed stays underwhelming and may be an issue when trying to collect images fast, but the server does not crash and displays some visualization of the reciprocal space properly.