Experiment/58 wslc support#72
Conversation
| // kan zijn), daarna naar `podman`. Zo wint een echte Docker-engine als die er | ||
| // is, maar herkennen we Podman ook als het zich als `docker` voordoet. | ||
| const detected = detectEngine('docker') ?? detectEngine('podman'); | ||
| const detected = detectEngine('docker') ?? detectEngine('podman') ?? detectEngine('wslc'); |
There was a problem hiding this comment.
Auto-detect includes detectEngine('wslc'), but detectEngine never returns wslc (only podman or docker), so wslc cannot be auto-selected despite the new detection chain.
Details
✨ AI Reasoning
The change aims to include a third runtime in auto-detection. However, the detection helper only ever maps a reachable command to one of two engine names. As a result, adding the third command to the fallback chain cannot actually select that third runtime in auto-detect mode. This creates a direct contradiction between the documented/advertised behavior and what this control flow can produce.
🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Summary
Related issue
Fixes #
Type of change
fix)feat)docs)refactor/chore)Checklist
mainand focused on a single change.npm --prefix gateway test) and I added/updated tests where relevant.Notes for reviewers