Skip to content

Experiment/58 wslc support#72

Closed
insuT0ver wants to merge 3 commits into
mainfrom
experiment/58-wslc-support
Closed

Experiment/58 wslc support#72
insuT0ver wants to merge 3 commits into
mainfrom
experiment/58-wslc-support

Conversation

@insuT0ver

Copy link
Copy Markdown
Contributor

Summary

Related issue

Fixes #

Type of change

  • Bug fix (fix)
  • New feature (feat)
  • Documentation (docs)
  • Refactor / maintenance (refactor / chore)
  • Other:

Checklist

  • My branch is up to date with main and focused on a single change.
  • The project builds and type-checks locally.
  • Tests pass (npm --prefix gateway test) and I added/updated tests where relevant.
  • I ran Prettier and did not reformat unrelated code.
  • Commit messages follow Conventional Commits.
  • I did not introduce logging of secrets, tokens, or credentials.
  • Documentation is updated where needed (README / relevant docs).

Notes for reviewers

@insuT0ver
insuT0ver requested a review from a team July 20, 2026 06:47
Comment thread cli/src/runtime.ts
// kan zijn), daarna naar `podman`. Zo wint een echte Docker-engine als die er
// is, maar herkennen we Podman ook als het zich als `docker` voordoet.
const detected = detectEngine('docker') ?? detectEngine('podman');
const detected = detectEngine('docker') ?? detectEngine('podman') ?? detectEngine('wslc');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-detect includes detectEngine('wslc'), but detectEngine never returns wslc (only podman or docker), so wslc cannot be auto-selected despite the new detection chain.

Details

✨ AI Reasoning
​The change aims to include a third runtime in auto-detection. However, the detection helper only ever maps a reachable command to one of two engine names. As a result, adding the third command to the fallback chain cannot actually select that third runtime in auto-detect mode. This creates a direct contradiction between the documented/advertised behavior and what this control flow can produce.

🔧 How do I fix it?
Trace execution paths carefully. Ensure precondition checks happen before using values, validate ranges before checking impossible conditions, and don't check for states that the code has already ruled out.

Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

@insuT0ver insuT0ver closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants