ILLDEV-393: CONSORTIA_SYMBOL, holdingsConfig#597
Open
adamdickmeiss wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the directory entry's availabilityConfig field to holdingsConfig (and corresponding Go type) and renames the CONSORTIA_SYMBOL env var/field to CONSORTIUM_SYMBOL. Also adds a new GVI1 test peer in the dirmock fixtures and a new integration test exercising the consortia holdings adapter path.
Changes:
- Rename
AvailabilityConfig→HoldingsConfigacross the API spec, model usages, mock data, and tests. - Rename
CONSORTIA_SYMBOLenv var andconsortiaSymbol/getAdapterForConsortiasymbols toCONSORTIUM/Consortialvariants. - Add
broker/test/holdings/holdings_test.goplus three ISO18626 fixture XMLs and a newGVI1directory mock entry to cover holdings lookup scenarios.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| directory/directory_api.yaml | Renames availabilityConfig/AvailabilityConfig to holdingsConfig/HoldingsConfig in the OpenAPI schema. |
| broker/app/app.go | Renames CONSORTIA_SYMBOL env var to CONSORTIUM_SYMBOL and updates SupplierLocator wiring. |
| broker/README.md | Updates configuration table for the renamed env var. |
| broker/service/supplierlocator.go | Renames field, parameter, and helper to use "consortium"/"consortial" naming. |
| broker/holdings/creator_impl.go | Updates GetAdapter to read HoldingsConfig. |
| broker/holdings/adapter_mock.go | Updates mock adapter constructor signature to take HoldingsConfig. |
| broker/holdings/creator_test.go | Updates tests to use the renamed type. |
| broker/holdings/gvi_holdings_test.go | Updates test fixture to use HoldingsConfig. |
| broker/test/service/supplierlocator_test.go | Updates Z39.50 tests to use the renamed type and refreshed comments. |
| broker/test/holdings/holdings_test.go | New integration test for consortia-mode holdings flows. |
| broker/test/holdings/request-1.xml | New ISO18626 fixture (unknown requester). |
| broker/test/holdings/request-2.xml | New ISO18626 fixture (requester w/o holdings config). |
| broker/test/holdings/request-3.xml | New ISO18626 fixture (requester with holdings config). |
| illmock/dirmock/directories.json | Adds GVI1 directory entry used by the new test. |
jakub-id
reviewed
May 15, 2026
jakub-id
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.