Fix race condition when creating s3 buckets#594
Merged
ktrops merged 3 commits intoOct 29, 2025
Merged
Conversation
…s not already created before exiting
1cf2223 to
28177cb
Compare
longquanzheng
approved these changes
Oct 23, 2025
Contributor
|
changing bitnami to bitnamilegacy in all of the docker-compose/ dependencies.ymls should make the tests pass. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 65.87% 65.84% -0.04%
==========================================
Files 64 64
Lines 6433 6433
==========================================
- Hits 4238 4236 -2
- Misses 1870 1872 +2
Partials 325 325 🚀 New features to boost your workflow:
|
Contributor
Author
thanks |
Contributor
|
I think it's ok to merge even if codecov isn't passing. In my MR i've added config. |
ktrops
approved these changes
Oct 29, 2025
Contributor
|
You'll need to rebase main to pull in my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explanation of bug:
When trying to run the lite docker container using
It exits and I get this error
Note how both
2025/10/15 00:43:46 bucket created successfully: iwf-test-bucketand2025/10/15 00:43:46 failed to create bucket{{error 26 0 0xc000a86c30}}are logedfrom what I can tell this ends up invoking
createBucketIfNotExiststwice (for interpreter and api) in parallel. Both detect that the bucket is missing one creates the bucket and the other fails to create the bucket because it already exists.Checklist
Related Issue
Closes #issue_number