Skip to content

Fix range filter bug on paging, don't sort on values #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbrant1 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix range filter bug on paging, don't sort on values #67

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5b9563
Fix range filter bug on paging, don't sort on values
Oct 16, 2018
54e01c1
Removed accidentally added pass line
lbrant1 Oct 26, 2018
4fd910e
Set values before check, make sure contains at least one true item in…
lbrant1 Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions seeker/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,16 +315,14 @@ def normalized_querystring(self, qs=None, ignore=None):
for key in sorted(data):
if ignore and key in ignore:
continue
if not data[key]:
if not data.getlist(key) or not any(data.getlist(key)):

@lefcourn lefcourn Oct 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put "values = data.getlist(key)" above this and just do the "any" check?

continue
if key == 'p' and data[key] == '1':
continue
values = data.getlist(key)
# Make sure display/facet/sort fields maintain their order. Everything else can be sorted alphabetically for consistency.
if key not in ('d', 'f', 's'):
values = sorted(values)
parts.extend(urlencode({key: val}) for val in values)
return '&'.join(parts)
pass

@lefcourn lefcourn Oct 26, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this here for?


def get_field_label(self, field_name):
"""
Expand Down