PNG: Stricter XMP detection#3004
Merged
Merged
Conversation
Shnatsel
approved these changes
May 30, 2026
Member
Shnatsel
left a comment
Shnatsel
left a comment
There was a problem hiding this comment.
The spec does clearly state that you should perform an exact match, not a substring search.
I checked for mentions of software that writes non-standard XMP names, and only imagemagick came up that writes it to Raw profile type xmp or Raw profile type XMP depending on the version (and also to a zTXt chunk instead of iTXt, and does other cursed stuff with it).
So this should not regress compatibility in any way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses L43 from #2954.
I think literal equality should be correct here, because the PNG spec says that keyword should be comparably by equality and because of Wikipedia.