Add some debug asserts to help with local reasoning#2979
Open
RunDevelopment wants to merge 2 commits into
Open
Add some debug asserts to help with local reasoning#2979RunDevelopment wants to merge 2 commits into
RunDevelopment wants to merge 2 commits into
Conversation
197g
reviewed
May 23, 2026
|
|
||
| impl YuvIntensityRange { | ||
| pub(crate) const fn get_yuv_range(self, depth: u32) -> YuvChromaRange { | ||
| debug_assert!(matches!(depth, 8..=16)); |
Member
There was a problem hiding this comment.
We seem to be checking the bit depth in all individual callers:
assert!(
(8..=16).contains(&BIT_DEPTH),
"Invalid bit depth is provided"
);
With this being an internal but supposedly local reasoning maybe we should use a simple wrapper type for it instead of u32 in this case?
Member
Author
There was a problem hiding this comment.
Might be tricky. Before this function, bit depth is passed around with const generics everywhere. So switching to a parameter might make perf worse. I can't test this though, since avif-native doesn't work on my machine (out of the box).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses L46 and L47 from #2954.