Optimize pixel map operations#2978
Open
RunDevelopment wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 2 internal functions,
map_pixelsandmap_pixels_in_place, that I used to re-implement color operations. These new functions contain fast paths based on::to_pixel_viewand::to_pixel_view_mut.Interestingly, this did not speed up color operations as much as I expected:
Note: The benchmark for
invertmakes a full copy of the input image before applying the operation. This probably eats a lot of the improvement.Still good, but I expected more. I suspect that the branch predictor helped a lot before.
Anyway, I only ported 3 functions for now. I'd like to do
brightenand co in a separate PR, because I want to take this chance to remove their code duplication.Open questions:
GenericImageandGenericImageView? They seem useful for users.