Conversation
4da98c2 to
89fb99e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 46 46
Lines 4337 4337
=====================================
Hits 4147 4147
Misses 190 190 |
0425eb0 to
684dea9
Compare
glatterf42
approved these changes
Nov 22, 2024
Member
Author
|
@glatterf42 FYI this appears not to have worked exactly as intended 🥲 When I opened #894:
I'll make a note to come back and revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the approach recommended by this article from Github's ‘Security Lab’ to allow the usage of secrets on PRs from forks of the
message_ixrepository.main.workflow_run:event trigger. Invoke this trigger every time the "receive" workflow completes (success or failure).pytestandtutorialsjobs if the "receive" workflow failed.With this merged, it would be up to some user with ‘write’ permissions on the current repo to give a first look-over of any PR from and then add the "safe to test" label. (The label could also be removed again at any time.)
How to review
Per the documentation:
This means we will need to:
.tools.sankeyand tutorial #770 was suggested).pytestworkflow is invoked and runs successfully; if not, open a follow-up PR to adjust the workflow(s).PR checklist
Add or expand tests; coverage checks both ✅N/A; CI changes onlyAdd, expand, or update documentation.Update release notes.