Ensure imports also have historical activity in bilateralization#480
Draft
junukitashepard wants to merge 3 commits into
Draft
Ensure imports also have historical activity in bilateralization#480junukitashepard wants to merge 3 commits into
junukitashepard wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
- Coverage 73.3% 73.3% -0.1%
=======================================
Files 301 301
Lines 24429 24430 +1
=======================================
Hits 17914 17914
- Misses 6515 6516 +1
🚀 New features to boost your workflow:
|
Contributor
Author
|
The same tests used for bare_to_scenario and historical_calibration should cover these changes. |
caca359 to
d710102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure imports also have historical activity in bilateralization.
The current bilateralize tool leads to certain commodities not being balanced at the trade level (e.g., "shipped", "piped"). This is due to improper historical calibration of imports.
How to review
PR checklist