Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
- Coverage 78.5% 77.7% -0.9%
=======================================
Files 216 216
Lines 17409 17409
=======================================
- Hits 13679 13531 -148
- Misses 3730 3878 +148 🚀 New features to boost your workflow:
|
This was referenced Nov 28, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal PR to check that the message-ix-model test suite runs using ixmp4 storage (i.e. without the ixmp.JDBCBackend and underlying Java code). To do this, it:
ixmp.testing.test_mpfixture to yield either the current ixmp.JDBCBackend-backed test Platform, or an ixmp4-backed test Platform.message_ix.testswill pass with the code on message_ixmainbranch. However, using that branch makes for smaller adjustments to the GitHub Actions workflows here.)message_ix_models.testssuite, with either storage option. (MESSAGEix-GLOBIOM workflows and downstream/user code rely on this behaviour.)Implementation/to dos:
ixmp.testing.test_mp, all tests inmessage_ix_models.teststhat use thetest_mpfixture will run twice: once with JDBCBackend, and once with ixmp4.Some things not in scope for this PR:
ixmpormessage_ix.How to review
TBA
PR checklist