Add ixmp4-backed platform functions#556
Closed
glatterf42 wants to merge 9 commits into
Closed
Conversation
Member
Author
|
Superseded by #557 from within this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #552 (comment), this PR adds
IXMP4Backendfunctions that are required to pass thetest_platformtests. This is separate to keep the PR reviews manageable.As far as passing the test_platform tests go, this work is incomplete. In some places, I'm not sure best to proceed. For example,
test_add_regionandtest_add_region_synonymare currently failing because the regions-DataFrame returned from the ixmp4 Backend does not include the data the tests currently expect. This is in turn due to the ixmp4 DB model for regions is different from the one in ixmp.Most notably, ixmp4 requires the
hierarchyparameter, but doesn't useparentorsynonym. I asked @meksor and @danielhuppmann about this and they said that's on purpose and ixmp doesn't really use these parameters anymore, either. So I think it should be fine to adapt the existing tests, but please let me know what you think, @khaeru.Similarly, ixmp4 does not seem to store timeslices in a similar way to the JDBC. It looks like I'll have to add this feature first, but I'm not really familiar with the IAMC data storage we currently have implemented.
Another missing feature is the ability to delete stuff in ixmp4. Both optimization data and items as well as
Runs as a whole still lack this.There are several more open questions marked as
TODOinline. For example:ixmp4.Run.clone()doesn't supportfirst_model_yearandplatform_dest. How crucial are these features?How to review
Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review: …” and describe why.
PR checklist