Implement ixmp4 shim#516
Closed
khaeru wants to merge 10 commits into
Closed
Conversation
khaeru
commented
Jan 25, 2024
| # WHERE run.is_default = 1 ORDER BY run.id ASC] | ||
| return self._platform.runs.list() | ||
|
|
||
| # The below methods of base.Backend are not yet implemented |
Member
Author
There was a problem hiding this comment.
FYI @glatterf42, the idea is that to remove lines like name = _ni below as each method gets a concrete implementation, in parallel with tests that exercise it.
khaeru
commented
Jan 25, 2024
| with pytest.raises(AttributeError): | ||
| test_mp.not_a_direct_backend_method | ||
|
|
||
| def test_scenario_list(self, mp): |
Member
Author
There was a problem hiding this comment.
Currently fails (e.g. here) with:
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: run
[SQL: SELECT DISTINCT run.model__id, run.scenario__id, run.version, run.is_default, run.id
FROM run
WHERE run.is_default = 1 ORDER BY run.id ASC]
Member
Author
|
The Python 3.12 job fails with different exceptions than 3.10 and 3.11, for instance here: I guess this means ixmp4 does not support Python 3.12, although it is installable. |
e6624c2 to
92ee78d
Compare
92ee78d to
3e38bf0
Compare
2 tasks
6 tasks
Attempts to initialize each of JDBCBackend and IXMP4Backend.
3e38bf0 to
0c9022f
Compare
khaeru
added a commit
to iiasa/message_ix
that referenced
this pull request
Nov 28, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #552 with a renamed branch.
This PR is intended to aid @glatterf42 in developing model data features in ixmp4. It is not a complete plan or solution for migrating ixmp-based code, workflows, and research to ixmp4; such a plan would involve many additional elements that are not in scope for this PR.
The PR:
ixmp.Platformbacked by IXMP4Backend to be created and used.Notes
ixmp4from thetestsdependency, and don't install it on those Pythons.How to review
TBD. This branch/PR may not necessarily be merged itself, but may serve as the basis for another PR that adds the IXMP4Backend.
PR checklist