-
Notifications
You must be signed in to change notification settings - Fork 0
feat(offer): Wallapop 'hacer oferta' flow — operator-tapped offers + negotiable band #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| schema: spec-driven | ||
| created: 2026-07-22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Capture notes — wallapop-make-offer | ||
|
|
||
| ## App captures (2026-07-22, files in this directory) | ||
|
|
||
| - `app-listing-hacer-oferta-button.jpg` — listing page with "Hacer oferta" | ||
| next to Comprar. | ||
| - `app-offer-form-10-restantes.jpg` — offer form showing the | ||
| "10 ofertas restantes para hoy" counter. | ||
| - `app-offer-form-floor-30pct.jpg` — inline floor validation: | ||
| "Tu oferta debe ser de al menos 35€ (-30%)" on a 50 € item. | ||
|
|
||
| ## Web verification (2026-07-23, operator screenshots — task 5.1) | ||
|
|
||
| Confirmed on es.wallapop.com (desktop web, authenticated session): | ||
|
|
||
| - The listing page (`/item/<slug>`) shows a "Hacer oferta" button | ||
| directly under Comprar — same entry point as the app. | ||
| - Clicking opens the "Hacer una oferta" modal, addressable at | ||
| `/app/chat/offer?itemId=<internal id>` (the SAME internal id the | ||
| reconciliation re-fetch uses; carried in the agent goal as a | ||
| recovery hint). | ||
| - The same "10 ofertas restantes para hoy" counter renders in the modal. | ||
| - The amount field accepts cents using a COMMA separator ("20,22" | ||
| observed accepted, Enviar enabled). Salvager's amounts are whole | ||
| euros, so no decimals are ever entered. | ||
| - No -30 % floor message was visible client-side at a below-floor | ||
| amount on web — validation may happen on submit; the domain | ||
| pre-validates the floor and `amount_rejected` covers a refusal. |
Binary file added
BIN
+602 KB
openspec/changes/wallapop-make-offer/captures/app-listing-hacer-oferta-button.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+230 KB
openspec/changes/wallapop-make-offer/captures/app-offer-form-10-restantes.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+262 KB
openspec/changes/wallapop-make-offer/captures/app-offer-form-floor-30pct.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Duplicate FR ids: FR50-FR54 now used twice with unrelated content.
The new offer-flow amendment claims FR50-FR57, but FR50 (SIGTERM handling, line 805) and FR51-FR54 (distribution artifacts, lines 809-812) already exist unchanged immediately below with the same ids. This breaks the FR-traceability contract this section states — every doc referencing "FR50-FR57" for the offer flow (the spec files, tasks.md, README) now also collides with the SIGTERM/distribution requirements.
🔧 Proposed fix: renumber the pre-existing FRs that follow the insertion point
🤖 Prompt for AI Agents