Skip to content

Fix: Remove panic risk in AST pragma processing #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VolodymyrBg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Remove panic risk in AST pragma processing #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions program_structure/src/abstract_syntax_tree/ast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@ impl AST {
let mut reports = Vec::new();
for p in pragmas {
match p {
// TODO: don't panic
// Handle version pragma without panicking
Pragma::Version(location, file_id, ver) => match compiler_version {
Some(_) => reports.push(produce_report(
ReportCode::MultiplePragma,location.start..location.end, file_id)),
ReportCode::MultiplePragma, location.location.clone(), file_id)),
None => compiler_version = Some(ver),
},
Pragma::CustomGates(location, file_id ) => match custom_gates {
Some(_) => reports.push(produce_report(
ReportCode::MultiplePragma, location.start..location.end, file_id)),
ReportCode::MultiplePragma, location.location.clone(), file_id)),
None => custom_gates = Some(true),
},
Pragma::Unrecognized => {}, //This error is previously handled, and the
Expand Down Expand Up @@ -655,4 +655,4 @@ pub fn tuple_general_error(meta : Meta, msg : String) -> Report {
"This is the tuple whose use is not allowed".to_string(),
);
report
}
}