Repository navigation
feat: option to exclude guest accounts from the everyone group - #39
Merged
Merged
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
icewind1991
requested changes
Sep 19, 2026
- Detect the Guests user backend with instanceof instead of its name. - Count disabled members from the disabled user list instead of loading every guest. - Search only the non-guest backends when guests are excluded. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
icewind1991
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Adds
occ group_everyone:exclude-guests [--on|--off](off by default, so existing instances are unchanged).Guests(the Guests app), so there is no code dependency on that app.UserRemovedEvent/UserAddedEventfor every guest. Without it, shares created while guests were excluded stay pending for them after--off, and other apps (Talk, etc.) never learn about the membership change.searchInGroupremoves guests using the guest backend'sgetDisplayNames()with the same search, limit and offset the user manager passes to every backend, so paging is unchanged.countDisabledInGrouphas no per-backend API, so it looks up each guest's enabled state when exclusion is on.Tested on Nextcloud 35.0.0 RC4 with Guests and Activity enabled, on PostgreSQL 16 and MariaDB 11.8: unit tests, plus an end-to-end run covering group membership, counts, and a folder shared with
everyonebefore and after--on/--off.