Detect service implementation of compute+setup and apply, definitions of supported representations and service docs fixes#934
Draft
thehrh wants to merge 20 commits into
Draft
Conversation
…ndividual services don't need to
…r new configurations
…pported_reps_and_doc_format
…verriding of abstract base methods
…by default, unless already set by subclass
…longer; add docstring note about absence of setup+compute/apply instead
…ner.mark_changed [no ci]
…nding function isn't implemented (for now, possibly change later) [no ci]
…d include md output in stage modes notebook for now (TODO: fix notebook) [no ci]
…tion_modes -> translation_modes; representation management unit test; update container module docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes and fixes:
setup_function,compute_function, orapply_functionviahas_setup,has_compute, andhas_applyfunction -> default deduction of allowed representations atStageleveldata.simple_signal, whereapply_mode=MultiDimBinningis assumed insetup_function, butapply_functionsets rep. to "events" (hard-coded) -> currently declares support ofMultiDimBinningNoneinstead of[None])Pipelinealready takes care of thatNoneeven though the corresponding function is implemented (see new tests incore.pipelinemodule)setup(),compute(), andapply()functions in case theStagesomehow became misconfigured (unlikely to have any significant performance impact on realistic pipelines IMO)Documentation improvements: