CM: Add FRU type identification from paths#8
Open
RameshaR45 wants to merge 7 commits into
Open
Conversation
Added asmitk01@in.ibm.com as an owner and reviewer of the repository. Also added OpenBMC community information for the maintainers. Entries are kept in alphabetical order. Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Add support for creating concurrent maintenance dbus object based on ReadyToRemove property change signal on inventory items. Key changes: - Added CMObject class to represent concurrent maintenance operations - Implemented ReadyToRemove property change signal monitoring - Create /com/ibm/concurrent_maintenance/remove when a FRU is needed to be concurrently replaced - Create /com/ibm/concurrent_maintenance/add when a FRU is added back Only one CM operation can be done at a time. If an operation is already in progress, new requests are rejected with an error log. Note: The CMObject class is currently a placeholder with TODO comments for future Progress interface implementation. When the Progress interface is added, it will track CM operation progress status of the FRU and completion time. Tested By: * Verified the CM object creation on property change (As of now, its listening on Available property change signals from inventory dbus objects for testing purposes. This will change to "ReadyToRemove" once the backend has changes): ** On value: false busctl tree com.ibm.ConcurrentMaintenance └─ /com └─ /com/ibm └─ /com/ibm/concurrent_maintenance └─ /com/ibm/concurrent_maintenance/add ** On value: true busctl tree com.ibm.ConcurrentMaintenance └─ /com └─ /com/ibm └─ /com/ibm/concurrent_maintenance └─ /com/ibm/concurrent_maintenance/remove ** When another request comes in, error will be thrown saying "CM operation already in progress" Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Add generic API to parse FRU object paths from inventory manager and identify FRU type (FSI, BMC, Switchboard, etc.). The API takes object path as input and returns the FRU type as output. Signed-off-by: Ramesha Rohit <ramesharohit45@gmail.com>
|
Can one of the admins verify this patch? |
|
|
||
| lg2::info("CM object created at {PATH}", "PATH", cmObjectPath); | ||
| lg2::info("CM object created at {PATH} for {TYPE} FRU", | ||
| "PATH", cmObjectPath, "TYPE", fruTypeStr); |
Contributor
There was a problem hiding this comment.
On rebasing, cmObjectPath will change to currentCMObject->getPath()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies
This PR depends on PR #4 (Implement CM object creation on property change)
This PR adds FRU type identification capability on top of the CM object infrastructure introduced in PR #4. The PR diff includes changes from PR #4 until it is merged. Once PR #4 is merged, this PR will automatically show only the FRU detection changes.