RBMC: Handle Status/Health for manager#1503
Open
jeaaustx wants to merge 1 commit into
Open
Conversation
The Status/Health of the Redundancy property of the Manager response
should reflect the current state. When redundancy is enabled and
failovers are allowed the Health should reflect OK. When redundancy is
not enabled or not allowed the Health should indicate Warning.
Tested:
- Redfish service validator passes for Managers
```
Note: Tested on both active and passive BMC. Mode and Status for
Redundancy are the same on each in each scenario.
/* Redundancy is enabled and allowed */
curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" https://${BMC_IP}/redfish/v1/Managers/bmc
{
[...]
"Redundancy": [
{
[...]
"Mode": "Failover",
[...]
"Status": {
"Health": "OK",
"State": "Enabled"
}
}
],
"Redundancy@odata.count": 1,
[...]
/* Redundancy is disabled */
curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" https://${BMC_IP}/redfish/v1/Managers/bmc
{
[...]
"Redundancy": [
{
[...]
"Mode": "NotRedundant",
[...]
"Status": {
"Health": "Warning",
"State": "Disabled"
}
}
],
"Redundancy@odata.count": 1,
[...]
/* Redundancy is enabled but not allowed */
curl -k -H "X-Auth-Token: $token" -H "Content-Type: application/json" https://${BMC_IP}/redfish/v1/Managers/bmc
{
[...]
"Redundancy": [
{
[...]
"Mode": "Failover",
[...]
"Status": {
"Health": "Warning",
"State": "Disabled"
}
}
],
"Redundancy@odata.count": 1,
[...]
```
Signed-off-by: Janet Adkins <janeta@us.ibm.com>
gtmills
reviewed
Jul 13, 2026
gtmills
reviewed
Jul 13, 2026
gtmills
approved these changes
Jul 13, 2026
jnin-dev
approved these changes
Jul 13, 2026
jnin-dev
left a comment
Contributor
There was a problem hiding this comment.
Beyond what Gunnar stated about the conditional, this looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Status/Health of the Redundancy property of the Manager response should reflect the current state. When redundancy is enabled and failovers are allowed the Health should reflect OK. When redundancy is not enabled or not allowed the Health should indicate Warning.
Tested: