Skip to content

Restrict Resource Dump Creation to service user #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asmithakarun wants to merge 1 commit into
base: 1120
Choose a base branch
from
Draft

Restrict Resource Dump Creation to service user #1408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions redfish-core/lib/log_services.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include "bmcweb_config.h"

#include "account_service.hpp"
#include "app.hpp"
#include "async_resp.hpp"
#include "dbus_singleton.hpp"
Expand Down Expand Up @@ -1111,6 +1112,22 @@ inline void createDump(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
}
if (resourceDumpParams.size() == 3)
{
// Check if admin user is initiating resource dump with
// non-empty pwd
std::string roleId =
getRoleIdFromPrivilege(req.session->userRole);
if (roleId == "Administrator")
{
if (std::holds_alternative<std::string>(
resourceDumpParams[2]) &&
!std::get<std::string>(resourceDumpParams[2]).empty())
{
BMCWEB_LOG_WARNING(
"Request to create resource dump failed. User has insufficient privilege.");
messages::insufficientPrivilege(asyncResp->res);
return;
}
}
createDumpParams.emplace_back(
"com.ibm.Dump.Create.CreateParameters.Password",
resourceDumpParams[2]);
Expand All @@ -1125,6 +1142,7 @@ inline void createDump(const std::shared_ptr<bmcweb::AsyncResp>& asyncResp,
"/redfish/v1/Systems/system/LogServices/Dump/Actions/LogService.CollectDiagnosticData"));
return;
}

createDumpParams.emplace_back(
"com.ibm.Dump.Create.CreateParameters.DumpType",
"com.ibm.Dump.Create.DumpType.Resource");
Expand Down