fix(batch): preserve per-item warnings across CLI and MCP - #355
Open
y4ho0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarningContextdiagnostics separately for each batch itemresults[]entryThe capture happens in the shared batch loop, so non-resident CLI, resident, MCP, and in-process batch execution inherit the same behavior.
Why
Batch items call the shared document handlers directly and bypass the standalone add/set wrappers that normally add handler warnings to their output. A successful mutation could therefore silently lose an advisory that the equivalent standalone command exposed.
Scope
This PR only restores warning propagation. It does not materialize missing Word styles or add downstream dangling-style validation.
Validation
dotnet build src/officecli/officecli.csproj -c Release --no-restore— passed with 0 errors; only the pre-existing nullable warning inExcelHandler.SheetShift.csisError=falseoutputFilespill path and retained the warning in the slim responsegit diff --check— passedFixes #350