fix(pptx): speaker notes scale to match slides - #332
Open
stephenswetonic wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the interactive HTML preview,
.slide-notesis sizedwidth: var(--slide-design-w)— the slide's design width. When the viewport is narrower than the slide,scaleSlides()scales.slidedown bysand resizes.slide-wrappertodesignW * s, but the notes box keeps its full design width.The notes panel therefore renders far wider than the slide above it, and its text is clipped at the viewport edge with no way to scroll to the cut-off portion.
Before

Fix
Apply the same scale factor to the notes box width, in both the scaled and the reset branch of
scaleSlides().How to verify
Narrow the browser window until the slide visibly shrinks to fit.
officecli view notes.pptx html -o preview.htmland opening that file works equally well for checking this.Note that this is only reproducible in the interactive preview: headless/screenshot mode sets
.slide-notes { display: none }(PowerPointHandler.HtmlPreview.cs:140), soview screenshotshows no notes either way.After
