fix(docx): recognize character-relative first-line indents - #287
Open
Bortlesboat wants to merge 1 commit into
Open
fix(docx): recognize character-relative first-line indents#287Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
view issuesreports that a Normal-style body paragraph is missing a first-line indent even when its OOXML indentation has a positivefirstLineCharsvalue.Fix
Treat either a non-zero absolute
FirstLinevalue or a positive character-relativeFirstLineCharsvalue as satisfying the existing first-line-indent check. The current hanging-indent, alignment, list, and text exemptions are unchanged.Validation
src/officecli/officecli.csprojin Release with .NET 10.firstLineChars=200before the change and confirmed it is absent afterward.firstLineChars=0still reports the warning.firstLineIndent=2cmremains accepted.officecli validate --json.Closes #283.