Fix OpenAI structured chat response handling - #60
Open
yinli-systems wants to merge 3 commits into
Open
yinli-systems wants to merge 3 commits into
yinli-systems wants to merge 3 commits into
Conversation
Signed-off-by: Kevin-Li-2025 <kxl474@student.bham.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_responsecall inOpenAIModelAdapter.structured_chatwith the existing response-handling pattern used bychatFixes #36.
Validation
Validated after merging the current upstream
main:Results: target test passed; Ruff lint and format checks passed; Python compilation passed.
Fault-injecting the original
self.handle_response(response)call made the focused test fail with the expectedAttributeError, confirming the test directly covers the reported runtime bug. Restoring the fix returned the suite to green.AI assistance
AI assistance was used to merge current upstream changes, strengthen the response-completeness assertion, run fault-injection validation, and refine this PR description. The resulting changes and validation evidence were reviewed before submission.