Skip to content

PRO-810: Added ADR for user permissions - #1636

Open
252afh wants to merge 1 commit into
mainfrom
elliotmoore/pro-810-user-permission-decisions
Open

252afh wants to merge 1 commit into
mainfrom
elliotmoore/pro-810-user-permission-decisions

Conversation

@252afh

@252afh 252afh commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Context

A decision was needed on user permissions to advance the work in data setup, this adds an ADR to keep track of that decision.

Changes proposed in this pull request

  • Add an ADR for user permissions MVP decisions

@252afh
252afh requested a review from a team as a code owner September 17, 2026 08:16
@252afh
252afh requested review from ekin-odabas and removed request for a team September 17, 2026 08:16
@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

PRO-810

@github-actions

This comment was marked as outdated.

@252afh
252afh force-pushed the elliotmoore/pro-810-user-permission-decisions branch from 6103be4 to e9b4fd0 Compare September 17, 2026 08:20
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@252afh
252afh force-pushed the elliotmoore/pro-810-user-permission-decisions branch from f69fa61 to 3cf8792 Compare September 17, 2026 12:52
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as low quality.

@252afh
252afh force-pushed the elliotmoore/pro-810-user-permission-decisions branch from c5af019 to 5f9395e Compare September 17, 2026 15:19
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Claude finished @252afh's task in 17s —— View job


Review

Adds ADR-0016 for user permissions MVP (2-tier: superuser + user), superseding ADR-0012's 3-tier plan. Clean and well-structured.


docs/architecture/decisions/0016-user-permissions-mvp.md:49

⚪️ NIT: "The permissions will need double-handling" is vague. Consider clarifying what double-handling means (e.g., "Permissions logic will need to be revisited and migrated when the 3-tier structure is implemented").


@252afh
252afh enabled auto-merge (squash) September 18, 2026 07:19
…in MVP and updated 0012-minimum-self-serve-decision.md to be superseded by 0016
@252afh
252afh force-pushed the elliotmoore/pro-810-user-permission-decisions branch from 5f9395e to ba5b0b6 Compare September 18, 2026 09:03
@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @252afh's task in 15s —— View job


Review

Adds ADR-0016 for a 2-tier permissions MVP (superuser + user), superseding ADR-0012's 3-tier plan. Well-structured and clear.


docs/architecture/decisions/0016-user-permissions-mvp.md:49

⚪️ NIT: "The permissions will need double-handling" is vague. Consider clarifying — e.g., "Permissions logic will need to be revisited and migrated when the 3-tier structure is implemented later in the year." Fix this →


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants