Deleted remote activity fails

[fauno]

I got an "Error deleting activity, must have activity URL in object field" exception while removing the activity from #97 but I don't have access to the original Delete activity to check what happened.

By reading app/serializers/activitypub/delete_serializer.rb at Mastodon, I think it's sending something like this (relevant attributes only):

{
  "type": "Delete",
  "object": {
    "id": "Object ID",
    "type": "Tombstone"
  }
}

While src/server/apsystem.ts is expecting:

{
  "type": "Delete",
  "object": "Object ID"
}

[fauno]

I'm working on a PR

[RangerMauve]

Is this fixed now?

[fauno]

nope, it throw another error. i can still find the Create activity with id https://todon.nl/users/f/statuses/113912555011197377/activity on the inbox, and since it's removing the object by id it doesn't seem to have been indexed by it?

NotFoundError: Activity not found for URL: https://todon.nl/users/f/statuses/113912555011197377
    at ActivityStore.get (file:///mnt/vdb1/home/social/social.distributed.press/src/server/store/ActivityStore.ts:129:13)
    at async ActivityStore.removeFromIndex (file:///mnt/vdb1/home/social/social.distributed.press/src/server/store/ActivityStore.ts:109:22)
    at async ActivityStore.remove (file:///mnt/vdb1/home/social/social.distributed.press/src/server/store/ActivityStore.ts:82:5)
    at async ActivityPubSystem.ingestActivity (file:///mnt/vdb1/home/social/social.distributed.press/src/server/apsystem.ts:554:7)
    at async Object.<anonymous> (file:///mnt/vdb1/home/social/social.distributed.press/src/server/api/inbox.ts:112:5)

[fauno]

the quick fix is that a remote Delete should be added to the inbox and remove the object from indexes. ie. when someone replies to a post, i shouldn't find the object on the replies collection of the post