add support for Velox EMD files containing EELS spectrum images#522
Open
PauTorru wants to merge 4 commits into
Open
add support for Velox EMD files containing EELS spectrum images#522PauTorru wants to merge 4 commits into
PauTorru wants to merge 4 commits into
Conversation
With the new EELS detector from TFS, velox now produces .emd files that contain EELS datasets along with all previously existing datasets. The emd reader now looks for them and reads them properly.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 88.88% 88.52% -0.37%
==========================================
Files 113 113
Lines 13045 13102 +57
Branches 2414 2425 +11
==========================================
+ Hits 11595 11598 +3
- Misses 910 963 +53
- Partials 540 541 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ericpre
reviewed
Jun 9, 2026
ericpre
left a comment
Member
There was a problem hiding this comment.
From a quick look, it looks good. It would need some test files - see guidelines in https://hyperspy.org/rosettasciio/contributing.html#making-test-data-files.
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Author
|
Looks like Eduardo beat me to it in PR #524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
With the new Iliad TFS systems being installed now there are .emd files that contain both EDX and EELS spectrum images. This pull request allows the reader to get the data and metadata of the EELS datasets and create the hspy signals.
Main Changes:
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),docs/readthedocs.org:rosettasciiobuild of this PR (link in github checks)Minimal example of the bug fix or the new feature