Skip to content

Fix a couple of bugs in the guest component bindgen #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syntactically merged 2 commits into from
Aug 13, 2026
Merged

Fix a couple of bugs in the guest component bindgen #1732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20acfb0
[hyperlight_component_util] guest: avoid extra impls for Eq bounded vars
syntactically Aug 12, 2026
2e72ca6
[hyperlight_component_util] guest: correctly set export as `cur_trait`
syntactically Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/hyperlight_component_util/src/guest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ use proc_macro2::TokenStream;
use quote::{format_ident, quote};

use crate::emit::{
FnName, ResolvedBoundVar, ResourceItemName, State, WitName, find_colliding_import_names,
import_member_names, kebab_to_exports_name, kebab_to_fn, kebab_to_getter,
kebab_to_imports_name, kebab_to_namespace, kebab_to_type, kebab_to_var, split_wit_name,
FnName, ResourceItemName, State, WitName, find_colliding_import_names, import_member_names,
kebab_to_exports_name, kebab_to_fn, kebab_to_getter, kebab_to_imports_name, kebab_to_namespace,
kebab_to_type, kebab_to_var, split_wit_name,
};
use crate::etypes::{Component, Defined, ExternDecl, ExternDesc, Handleable, Instance, Tyvar};
use crate::hl::{
Expand Down Expand Up @@ -99,10 +99,11 @@ fn emit_import_extern_decl<'a, 'b, 'c>(
ExternDesc::Type(t) => match t {
Defined::Handleable(Handleable::Var(Tyvar::Bound(b))) => {
// only resources need something emitted
let ResolvedBoundVar::Resource { rtidx } = s.resolve_bound_var(*b) else {
let noff = (s.var_offset as u32 + b) as usize;
let crate::etypes::TypeBound::SubResource = &s.bound_vars[noff].bound else {
return quote! {};
};
let rtid = format_ident!("HostResource{}", rtidx as usize);
let rtid = format_ident!("HostResource{}", noff);
Comment thread
syntactically marked this conversation as resolved.
let path = s.resource_trait_path(kebab_to_type(ed.kebab_name));
s.root_mod
.r#impl(path, format_ident!("Host"))
Expand Down Expand Up @@ -316,6 +317,7 @@ fn emit_component<'a, 'b, 'c>(
s.var_offset = 0;

s.is_export = true;
s.cur_trait = Some(export_trait.clone());

let exports = ct
.instance
Expand Down
Loading