add more tests for CaliperEngine#1706
Open
tunedev wants to merge 1 commit into
Open
Conversation
davidkel
requested changes
Sep 19, 2025
davidkel
left a comment
davidkel
left a comment
Contributor
There was a problem hiding this comment.
@tunedev Only a minor issue about how we setup the flow options and then just need to set the specific flow option to true that is being tested, plus cleanup of the whitespace. But all good apart from that, thanks for the PR (sorry it took so long to review)
| stubbedCaliperUtils.getFlowOptions.reset(); | ||
| stubbedCaliperUtils.execAsync.reset(); | ||
|
|
||
| stubbedCaliperUtils.getFlowOptions.returns({ |
Contributor
There was a problem hiding this comment.
Not sure why this is here and probably can be removed
| let mockAdapter; | ||
|
|
||
| beforeEach(() => { | ||
| benchSandbox = sinon.createSandbox(); |
Contributor
There was a problem hiding this comment.
I think it may be good here to set all the flows to false, then for each of the tests ensure that only the flows being tested get set.
| const testCMD = 'echo "Starting network"' | ||
|
|
||
| stubbedCaliperUtils.getFlowOptions.returns({ | ||
| performStart: true, |
Contributor
There was a problem hiding this comment.
Let's just set the flow option that is going to be tested here to true, and not include the others
|
|
||
| it('should handle errors during start command execution', function() { | ||
| // TODO: Implement test | ||
| it('should handle errors during start command execution', async function() { |
Contributor
There was a problem hiding this comment.
We should explicitly set the flow under test here
| }); | ||
|
|
||
| it('should handle a non-string start command', async function() { | ||
| const networkConfig = { caliper: { command: { start: 1234 } } } |
Contributor
There was a problem hiding this comment.
We should explicitly set the flow under test here
| }); | ||
|
|
||
| const engine = new CaliperEngine({}, {}, () => {throw new Error('Failed to create adapter')}); | ||
|
|
| performInit: false, | ||
| performInstall: false, | ||
| performTest: false, | ||
| performEnd: true |
| stubbedConfigUtils.get.withArgs('caliper-workspace').returns('./'); | ||
| stubbedCaliperUtils.execAsync.resolves(); | ||
| const engine = new CaliperEngine({}, networkConfig, () => mockAdapter); | ||
|
|
| performInit: false, | ||
| performInstall: false, | ||
| performTest: false, | ||
| performEnd: true |
tunedev
force-pushed
the
add-more-tests-to-caliper-engine
branch
from
December 2, 2025 10:21
8637b09 to
bd1c2e7
Compare
Signed-off-by: Babatunde Sanusi <swisskid95@gmail.com>
tunedev
force-pushed
the
add-more-tests-to-caliper-engine
branch
from
December 2, 2025 10:25
bd1c2e7 to
ad0c2d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue/User story
Partially addresses #1557
Steps to Reproduce
Existing issues
Design of the fix
Validation of the fix
After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed
Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before
What documentation has been provided for this pull request